Skip to content

Conversation

codeql-ci
Copy link
Collaborator

No description provided.

@dbartol
Copy link

dbartol commented Apr 21, 2022

@MathiasVP I just pushed a bunch of commits to fix formatting issues in the change logs. One change note that applied to nearly all languages was missing a bullet, and a couple others had leading spaces before the bullet. I wonder if we can catch this sort of thing automatically, without having to thoroughly parse markdown.

@MathiasVP
Copy link
Contributor

@MathiasVP I just pushed a bunch of commits to fix formatting issues in the change logs. One change note that applied to nearly all languages was missing a bullet, and a couple others had leading spaces before the bullet. I wonder if we can catch this sort of thing automatically, without having to thoroughly parse markdown.

Yeah, I was thinking the exact same thing while I was watching the commits come in 😄. Thanks a lot! Should I create a core team issue for this?

@jketema
Copy link
Contributor

jketema commented Apr 21, 2022

One change note that applied to nearly all languages was missing a bullet

That's my fault. I caught that, but the bullets got lost in a rebase. My apologies.

@MathiasVP MathiasVP merged commit 7df7e99 into codeql-cli-2.9.0 Apr 21, 2022
@MathiasVP MathiasVP deleted the release-prep/2.9.0 branch April 21, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants