Skip to content

C++: Work around missing size for typedef #8806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

dbartol
Copy link

@dbartol dbartol commented Apr 21, 2022

See #8805 for the underlying issue. The symptom was bad IR generation on a large number of functions because we never generated an IRVariable for a parameter with the affected type.

See #8805 for the underlying issue. The symptom was bad IR generation on a large number of functions because we never generated an `IRVariable` for a parameter with the affected type.
@dbartol dbartol added the C++ label Apr 21, 2022
@dbartol dbartol requested a review from rdmarsh2 April 21, 2022 20:17
@dbartol dbartol requested a review from a team as a code owner April 21, 2022 20:17
@dbartol dbartol added the no-change-note-required This PR does not need a change note label Apr 21, 2022
@owen-mc owen-mc changed the title Work around missing size for typedef C++: Work around missing size for typedef Apr 21, 2022
Copy link
Contributor

@jketema jketema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rdmarsh2 rdmarsh2 merged commit ebdf553 into github:main Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants