Skip to content

Conversation

erik-krogh
Copy link
Contributor

#8748 added a copy of TaintTrackingImpl.qll.

But the shared implementation changed in the meantime.
So now we got the sync files check failing on main.

@erik-krogh erik-krogh requested a review from a team as a code owner April 22, 2022 08:38
@github-actions github-actions bot added the Java label Apr 22, 2022
@erik-krogh erik-krogh added the no-change-note-required This PR does not need a change note label Apr 22, 2022
@aibaars
Copy link
Contributor

aibaars commented Apr 22, 2022

The error message from QLDoc seems genuine:

A fatal error occurred: Errors during binding:
ERROR: This predicate does not override another predicate (/home/runner/work/codeql/codeql/java/ql/lib/semmle/code/java/dataflow/internal/tainttracking3/TaintTrackingImpl.qll:118,3-120,4)
ERROR: This predicate does not override another predicate (/home/runner/work/codeql/codeql/java/ql/lib/semmle/code/java/dataflow/internal/tainttracking3/TaintTrackingImpl.qll:135,3-137,4)

@erik-krogh
Copy link
Contributor Author

The error message from QLDoc seems genuine:

Yes. I'm confused about which file is actually the latest.

@aschackmull
Copy link
Contributor

The error message from QLDoc seems genuine:

Yes. I'm confused about which file is actually the latest.

Presumably that error is from main, and a side-effect of the files being out-of-sync. The change in this PR looks like the right fix to me.

@erik-krogh
Copy link
Contributor Author

Presumably that error is from main, and a side-effect of the files being out-of-sync. The change in this PR looks like the right fix to me.

Yes. Parts of the failing CI check is: HEAD is now at d309e150 Merge pull request #8748 from smowton/smowton/admin/dependent-dataflow-configs, which suggests that it is trying to compare against the failing main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants