Skip to content

Java: Add value-preserving flow steps for Android's SharedPreferences #8817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 25, 2022
Merged

Java: Add value-preserving flow steps for Android's SharedPreferences #8817

merged 3 commits into from
Apr 25, 2022

Conversation

atorralba
Copy link
Contributor

@atorralba atorralba commented Apr 22, 2022 •
edited
Loading

Adds fluent steps for the SharedPreferences$Editor class.

@atorralba atorralba requested a review from a team as a code owner April 22, 2022 15:47
@github-actions github-actions bot added the Java label Apr 22, 2022
@atorralba atorralba changed the title Add value-preserving steps for SharedPreferences Java: Add value-preserving flow steps for Android's SharedPreferences Apr 22, 2022
@github-actions
Copy link
Contributor

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

java

Generated file changes for java

  • Changes to framework-coverage-java.rst:
-    Android,``android.*``,46,416,108,,,3,67,,,
+    Android,``android.*``,46,424,108,,,3,67,,,
-    Totals,,183,6225,1441,106,6,10,107,33,1,81
+    Totals,,183,6233,1441,106,6,10,107,33,1,81
  • Changes to framework-coverage-java.csv:
- android.content,24,27,100,,,,,,16,,,,,,,,,,,8,,,,,,,,27,,31,69
+ android.content,24,27,108,,,,,,16,,,,,,,,,,,8,,,,,,,,27,,31,77

@github-actions
Copy link
Contributor

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

java

Generated file changes for java

  • Changes to framework-coverage-java.rst:
-    Android,``android.*``,46,416,108,,,3,67,,,
+    Android,``android.*``,46,424,108,,,3,67,,,
-    Totals,,183,6225,1441,106,6,10,107,33,1,81
+    Totals,,183,6233,1441,106,6,10,107,33,1,81
  • Changes to framework-coverage-java.csv:
- android.content,24,27,100,,,,,,16,,,,,,,,,,,8,,,,,,,,27,,31,69
+ android.content,24,27,108,,,,,,16,,,,,,,,,,,8,,,,,,,,27,,31,77

@github-actions
Copy link
Contributor

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

java

Generated file changes for java

  • Changes to framework-coverage-java.rst:
-    Android,``android.*``,46,416,108,,,3,67,,,
+    Android,``android.*``,46,424,108,,,3,67,,,
-    Totals,,183,6225,1441,106,6,10,107,33,1,81
+    Totals,,183,6233,1441,106,6,10,107,33,1,81
  • Changes to framework-coverage-java.csv:
- android.content,24,27,100,,,,,,16,,,,,,,,,,,8,,,,,,,,27,,31,69
+ android.content,24,27,108,,,,,,16,,,,,,,,,,,8,,,,,,,,27,,31,77

@atorralba atorralba merged commit 85d5b12 into github:main Apr 25, 2022
@atorralba atorralba deleted the atorralba/cleartext-storage-sharedprefs-improvs branch April 25, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschackmull aschackmull aschackmull approved these changes

Assignees
No one assigned
Labels
documentation Java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atorralba @aschackmull