Data flow: Introduce expectsContent
#8870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathiasVP
reviewed
Apr 26, 2022
hvitved
force-pushed
the
dataflow/expect-content
branch
from
659b54a to
a597007
Compare
michaelnebel
previously approved these changes
May 3, 2022
aschackmull
reviewed
May 3, 2022
aschackmull
reviewed
May 3, 2022
aschackmull
reviewed
May 3, 2022
aschackmull
previously approved these changes
May 3, 2022
hvitved
force-pushed
the
dataflow/expect-content
branch
from
3ce21c5 to
74e9930
Compare
|
Rebased in order to be able to get successful DCA runs. |
michaelnebel
approved these changes
May 4, 2022
owen-mc
added a commit
to owen-mc/codeql
that referenced
this pull request
Nov 9, 2022
Corresponds to github#8870
owen-mc
added a commit
to owen-mc/codeql
that referenced
this pull request
Nov 9, 2022
Corresponds to github#8870
owen-mc
added a commit
to owen-mc/codeql
that referenced
this pull request
Nov 9, 2022
Corresponds to github#8870
owen-mc
added a commit
to owen-mc/codeql
that referenced
this pull request
Nov 17, 2022
Corresponds to github#8870
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have
clearsContent(Node n, ContentSet c), and this PR introduces the dualexpectsContent(Node n, ContentSet c). It currently has an empty stub implementation for all languages, but it will be used e.g. to give a proper flow summary for Ruby's splat operator.