C++: Revert #8515 #8933
Merged
C++: Revert #8515 #8933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathiasVP
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
7
to
+8
| private newtype TIRFunction = | ||
| TFunctionIRFunction(Language::Function func) { IRConstruction::Raw::functionHasIR(func) } or | ||
| TVarInitIRFunction(Language::GlobalVariable var) { IRConstruction::Raw::varHasIRFunc(var) } | ||
| MkIRFunction(Language::Function func) { IRConstruction::Raw::functionHasIR(func) } |
Check warning
Code scanning / CodeQL
Acronyms should be PascalCase/camelCase.
Comment on lines
7
to
+8
| private newtype TIRFunction = | ||
| TFunctionIRFunction(Language::Function func) { IRConstruction::Raw::functionHasIR(func) } or | ||
| TVarInitIRFunction(Language::GlobalVariable var) { IRConstruction::Raw::varHasIRFunc(var) } | ||
| MkIRFunction(Language::Function func) { IRConstruction::Raw::functionHasIR(func) } |
Check warning
Code scanning / CodeQL
Acronyms should be PascalCase/camelCase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing performance issues on some projects. We already have a fix for the performance here, but it's causing some new consistency failures in dataflow. So let's just revert the PR for now.
This reverts commit 800e4ea, reversing
changes made to 7ce040f.
DCA: https://github.com/github/codeql-dca-main/issues/4212