Swift: added trapgen #8934
Merged
Swift: added trapgen #8934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This checks in the trapgen script generating trap entries in C++. The codegen suite has been slightly reorganized, moving the templates directory up one level and chopping everything into smaller bazel packages. Running tests is now done via ``` bazel run //swift/codegen/test ``` With respect to the PoC, the nested `codeql::trap` namespace has been dropped in favour of a `Trap` prefix (or suffix in case of entries) within the `codeql` namespace. Also, generated C++ code is not checked in in git any more, and generated during build. Finally, labels get printed in hex in the trap file. `TrapLabel` is for the moment only default-constructible, so only one single label is possible. `TrapArena`, that is responsible for creating disjoint labels will come in a later commit.
AlexDenisov
approved these changes
Apr 28, 2022
There was a problem hiding this comment.
Overall, LGTM, though suggested command fails:
> bazel run //swift/codegen/test
Starting local Bazel server and connecting to it...
ERROR: Only a single target can be run. Your target pattern //swift/codegen/test expanded to the targets //swift/codegen/test:test_dbscheme, //swift/codegen/test:test_ql, //swift/codegen/test:test_qlgen, //swift/codegen/test:test_render, //swift/codegen/test:test_schema[TRUNCATED]
INFO: Elapsed time: 2.113s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (1 packages loaded)
FAILED: Build did NOT complete successfully (1 packages loaded)
whoops, that is a typo I fixed in the PR description 😅 should have been |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checks in the trapgen script generating trap entries in C++.
The codegen suite has been slightly reorganized, moving the templates
directory up one level and chopping everything into smaller bazel
packages. Running tests is now done via
With respect to the PoC, the nested
codeql::trapnamespace has beendropped in favour of a
Trapprefix (or suffix in case of entries)within the
codeqlnamespace. Also, generated C++ code is not checkedin in git any more, and generated during build. Finally, labels get
printed in hex in the trap file.
TrapLabelis for the moment only default-constructible, so only onesingle label is possible.
TrapArena, that is responsible for creatingdisjoint labels will come in a later commit, as well as
trapgenunit tests.