Skip to content

Swift: tracer integration #8939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 28, 2022
Merged

Swift: tracer integration #8939

merged 6 commits into from
Apr 28, 2022

Conversation

AlexDenisov
Copy link
Contributor

This was tested locally. Proper integration will come with an internal PR.

@github-actions github-actions bot added the Swift label Apr 28, 2022
@AlexDenisov AlexDenisov requested a review from redsun82 April 28, 2022 11:33
@AlexDenisov AlexDenisov marked this pull request as ready for review April 28, 2022 11:33
@AlexDenisov AlexDenisov requested a review from a team as a code owner April 28, 2022 11:33
igfoo
igfoo reviewed Apr 28, 2022
View reviewed changes
redsun82
redsun82 previously approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@redsun82 redsun82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll reapprove if you want to fix the typo in the TODO @igfoo has pointed out 🙂

AlexDenisov
AlexDenisov commented Apr 28, 2022
View reviewed changes
@redsun82 redsun82 self-requested a review April 28, 2022 14:59
redsun82
redsun82 approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@redsun82 redsun82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

cklin
cklin approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@cklin cklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at only the Lua tracing config, and that part is 👍

@AlexDenisov AlexDenisov merged commit f676973 into github:main Apr 28, 2022
@AlexDenisov AlexDenisov deleted the alexdenisov/swift-tracer-integration branch April 28, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igfoo igfoo igfoo left review comments

@cklin cklin cklin approved these changes

@redsun82 redsun82 redsun82 approved these changes

Assignees
No one assigned
Labels
Swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexDenisov @igfoo @cklin @redsun82