Skip to content

Conversation

redsun82
Copy link
Contributor

@redsun82 redsun82 commented May 9, 2022

Properties marked with predicate in the schema are now accepted.

  • in the dbscheme, they will translate to a table with a single id
    column (and the table name will not be pluralized)
  • in C++ classes, they will translate to bool fields
  • in QL classes, they will translate to predicates

Closes https://github.com/github/codeql-c-team/issues/1016

Properties marked with `predicate` in the schema are now accepted.

* in the dbscheme, they will translate to a table with a single `id`
  column (and the table name will not be pluralized)
* in C++ classes, they will translate to `bool` fields
* in QL classes, they will translate to predicates

Closes github/codeql-c-team#1016
@redsun82 redsun82 requested a review from MathiasVP May 9, 2022 15:56
@redsun82 redsun82 requested a review from a team as a code owner May 9, 2022 15:56
@github-actions github-actions bot added the Swift label May 9, 2022
@redsun82 redsun82 added the no-change-note-required This PR does not need a change note label May 9, 2022
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MathiasVP MathiasVP merged commit 66ca01a into github:main May 9, 2022
@redsun82 redsun82 deleted the swift-codegen-predicate-properties branch September 6, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-change-note-required This PR does not need a change note Swift
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants