Skip to content

Conversation

geoffw0
Copy link
Contributor

@geoffw0 geoffw0 commented May 11, 2022

Repair support for createLSParser in the CWE-611 XXE query, which it turned out was based on some incorrect information (see #9019).

Change note covered by the one in recent PR #8948.

@geoffw0 geoffw0 added C++ no-change-note-required This PR does not need a change note labels May 11, 2022
@geoffw0 geoffw0 requested a review from a team as a code owner May 11, 2022 10:14
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 1 vulnerability.

@geoffw0
Copy link
Contributor Author

geoffw0 commented May 11, 2022

Looks the the DCA run has failed, so I'll report it to the DCA team and start another.

@geoffw0
Copy link
Contributor Author

geoffw0 commented May 12, 2022

DCA LGTM. The query is a fraction slower, but its far from concerning and to be expected when adding features.

Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MathiasVP MathiasVP merged commit 39551fd into github:main May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants