Skip to content

Ruby: Add getAPrimaryQlClass to CfgNodes classes #9137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 23, 2022
Merged

Ruby: Add getAPrimaryQlClass to CfgNodes classes #9137

merged 2 commits into from
May 23, 2022

Conversation

hmac
Copy link
Contributor

@hmac hmac commented May 12, 2022 •
edited
Loading

I've excluded the ChildMapping classes because

  • they're not often directly used
  • they cause some test fixtures to bloat
  • they can subclass AST classes which have a final definition of getAPrimaryQlClass

@github-actions github-actions bot added the Ruby label May 12, 2022
@hmac hmac force-pushed the hmac/cfg-ql-class branch from 1a5f3c3 to 7e51d3c Compare May 12, 2022 14:19
@hmac hmac force-pushed the hmac/cfg-ql-class branch from 7e51d3c to 64206a1 Compare May 12, 2022 14:32
@hmac hmac marked this pull request as ready for review May 16, 2022 07:22
@hmac hmac requested a review from a team as a code owner May 16, 2022 07:22
@hmac hmac added the no-change-note-required This PR does not need a change note label May 16, 2022
@nickrolfe
Copy link
Contributor

I've excluded the ChildMapping classes

Is that also why you haven't added the method to the base CfgNode class?

@hmac
Copy link
Contributor Author

hmac commented May 23, 2022

I've excluded the ChildMapping classes

Is that also why you haven't added the method to the base CfgNode class?

Nope, that was just a total oversight! Fixed now.

@hmac hmac merged commit 905a37c into github:main May 23, 2022
@hmac hmac deleted the hmac/cfg-ql-class branch May 23, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickrolfe nickrolfe nickrolfe approved these changes

Assignees
No one assigned
Labels
no-change-note-required This PR does not need a change note Ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hmac @nickrolfe