Kotlin: Fix extraction of reflective call generated by Parcelize #9152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamasvajk
changed the title
smowton
approved these changes
May 13, 2022
We could, but
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the extraction of the
javaproperty call inC::class.javagenerated by the Parcelize plugin. Generally, these calls are properly associated tokotlin.jvm.JvmClassMappingKt::java, and therefore need no special handling. However, with the Parcelize plugin this is not the case.I'm planning on merging this fix without integration test. It feels way more effort to add the test than the benefit.