Java: Rename FloatingPointLiteral to FloatLiteral
#9181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Floating point" refers to both `double` and `float`, and is also used by the JLS in this way. Therefore the old CodeQL class name for `float` literals was misleading.
Marcono1234
commented
May 16, 2022
Comment on lines
-64
to
+54
| ee.getAnOperand().getType() instanceof Floating and | ||
| ee.getAnOperand().getType() instanceof FloatingPointType and |
There was a problem hiding this comment.
This change it not actually directly related, but I noticed it while searching for usages of the old expression name.
If you want I can revert this change.
Marcono1234
commented
May 16, 2022
Comment on lines
-18
to
+20
| | literals.kt:20:32:20:35 | 0.0 | FloatingPointLiteral | | ||
| | literals.kt:21:32:21:37 | 123.4 | FloatingPointLiteral | | ||
| | literals.kt:22:32:22:38 | -123.4 | FloatingPointLiteral | | ||
| | literals.kt:20:32:20:35 | 0.0 | FloatLiteral | | ||
| | literals.kt:21:32:21:37 | 123.4 | FloatLiteral | | ||
| | literals.kt:22:32:22:38 | -123.4 | FloatLiteral | |
There was a problem hiding this comment.
Could not verify whether this test still succeeds because test execution from within VS Code failed:
extraction error: #redacted#\codeql\java\ql\test\kotlin\library-tests\literals\literals.ql
IOException while executing process with args: [#redacted#\AppData\Roaming\Code\User\globalStorage\github.vscode-codeql\distribution23\codeql\java\tools\kotlin-extractor, --java-home, #redacted#\AppData\Roaming\Code\User\globalStorage\github.vscode-codeql\distribution23\codeql\tools\win64\java, --, -J-Xmx2G, literals.kt]
(eventual cause: IOException "CreateProcess error=193, %1 is not a valid Win32 application")
But I assume this is "expected" while Kotlin support is still work in progress.
aschackmull
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9170