Swift: make C++ code generation more self-contained #9198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to avoid bypassing label type correcness in the extractor, and allows to independently resolve TBD extractions, as with this approach TBD nodes do have the correctly typed trap label. The TBD status is now a predicate on the QL side. This requires: * a default visit using the correct type, which is achieved via macro metaprogramming in `VisitorBase.h`, following the way `swift::ASTVisitor` is programmed * a mapping from labels to corresponding binding trap entries. The functor is defined in `TrapTagTraits.h` and instantiated in generated `TrapEntries.h` * Binding trap entries for TBD unknown entities must not have any other field than the `id` (after all, we are supposed to not extract them yet). This is why all unextracted fields in `schema.yml` have been commented out, and will be uncommentend when visitors are added
This is solving a papercut, where the C++ build was relying on the local dbscheme file to be up-to-date, even if all the information for building is actually in `schema.yml`. This made a pure C++ development cycle with changes to `schema.yml` clumsy, as it required a further dbscheme generation step. Now for C++ the dbscheme is generated internally in the build files, and thus a change in `schema.yml` is reflected immediately in the C++ build. A `swift/codegen` step for checked in generated code (including the dbscheme) is still required, but a developer can do it just before running QL tests or committing, instead of during each C++ recompilation. Some directory reorganization was also carried out, moving specific generator modules to a new `generators` python package, and only leaving the two drivers at the top level.
AlexDenisov
previously approved these changes
May 17, 2022
redsun82
force-pushed
the
redsun82/swift-tbd-rework
branch
4 times, most recently
from
83e1071 to
da00bf9
Compare
AlexDenisov
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is solving a papercut, where the C++ build was relying on the
local dbscheme file to be up-to-date, even if all the information for
building is actually in
schema.yml. This made a pure C++ developmentcycle with changes to
schema.ymlclumsy, as it required a furtherdbscheme generation step.
Now for C++ the dbscheme is generated internally in the build files, and
thus a change in
schema.ymlis reflected immediately in the C++ build.A
swift/codegenstep for checked in generated code (including thedbscheme) is still required, but a developer can do it just before
running QL tests or committing, instead of during each C++
recompilation.
Some directory reorganization was also carried out, moving specific
generator modules to a new
generatorspython package, and only leavingthe two drivers at the top level.