Kotlin: fix implementation of SAM classes that inherit their abstract method #9213
+33
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, UnaryOperator<T> extends Function<T, T> without overriding / defining its own `apply` method.
smowton
force-pushed
the
smowton/fix/inherited-single-abstract-method
branch
from
f51ec28 to
e80254b
Compare
tamasvajk
reviewed
May 20, 2022
|
|
||
| fun extractNonFakeFunction(f: IrFunction, parentId: Label<out DbReftype>, extractBody: Boolean, extractMethodAndParameterTypeAccesses: Boolean, typeSubstitution: TypeSubstitution?, classTypeArgsIncludingOuterClasses: List<IrTypeArgument>?, idOverride: Label<DbMethod>? = null, locOverride: Label<DbLocation>? = null): Label<out DbCallable> { |
There was a problem hiding this comment.
extractNonFakeFunction is actually extracting fake and non-fake functions too, so its name is misleading. I think forceExtractFunction is somewhat better. Another option would be adding a Boolean parameter to extractFunction to skip the isFake test.
tamasvajk
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on / blocked by #9123