Skip to content

Data flow: Do not discard call context when computing reverse lambda flow through jumps #9214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 23, 2022

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented May 19, 2022

Since we are computing flow backwards, and we are recording the first call seen during reverse flow, it is valid to keep the call context even when we go through a jump step.

@hvitved hvitved marked this pull request as ready for review May 20, 2022 07:21
@hvitved hvitved requested review from a team as code owners May 20, 2022 07:21
@hvitved hvitved added the no-change-note-required This PR does not need a change note label May 20, 2022
Copy link
Contributor

@aschackmull aschackmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice fix.

@aschackmull aschackmull merged commit f221894 into github:main May 23, 2022
@hvitved hvitved deleted the dataflow/lambda-fp-flow branch May 23, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants