Swift: CFG for TypeExpr, MemberRefExpr, DefaultArgumentExpr and ForceValueExpr
#9284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OOI, have you enabled the CFG consistency queries for Swift, or would that be too noisy at this stage? |
We have not done that yet, no. That's probably a good thing to do next now that we have the entire CFG library in the CodeQL repo. Thanks for the reminder! I will add that once this PR has been merged. |
|
@rdmarsh2 I've marked you as a reviewer since I think you had actually started on the CFG for some of these before moving to dataflow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out we already extract those, but we forgot to include them in the CFG.