JS: Fix FP in js/type-confusion-through-parameter-tampering #9318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asgerf
added
JS
Awaiting evaluation
asgerf
force-pushed
the
js/type-confusion-parmaeter-tampering-barrier
branch
from
0207455 to
877a9d8
Compare
asgerf
removed
the
Awaiting evaluation
erik-krogh
reviewed
May 25, 2022
...t/ql/lib/semmle/javascript/security/dataflow/TypeConfusionThroughParameterTamperingQuery.qll
Outdated
Show resolved
Hide resolved
…usionThroughParameterTamperingQuery.qll Co-authored-by: Erik Krogh Kristensen <erik-krogh@github.com>
erik-krogh
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some barrier guards to
js/type-confusion-through-parameter-tamperingto help in cases where the local type-inference is not enough.Evaluation looks fine