Skip to content

JavaScript: Add Range.prototype.createContextualFragment as an XSS sink. #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2019

Conversation

xiemaisi
Copy link

Recently mentioned by a prospect. They didn't specifically ask us to add support, so no need for a change note.

This change was actually part of the evaluation of #910, but didn't cause any of the changes observed there.

@xiemaisi xiemaisi added the JS label Feb 12, 2019
@xiemaisi xiemaisi requested a review from a team as a code owner February 12, 2019 16:36
Copy link
Contributor

@asger-semmle asger-semmle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@semmle-qlci semmle-qlci merged commit f5e419e into github:master Feb 20, 2019
@xiemaisi xiemaisi deleted the js/createContextualFragment branch March 13, 2019 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants