Kotlin: use the same mtimes as Java #9331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igfoo
previously approved these changes
May 25, 2022
| private static long getVirtualFileTimeStamp(VirtualFile vf, Logger log) { | ||
| if (vf.getFileSystem().getProtocol().equals("jar")) { | ||
| String[] parts = vf.getPath().split("!/"); | ||
| if (parts.length == 2) { |
There was a problem hiding this comment.
Should we warn on != 2 (or perhaps > 2)?
smowton
force-pushed
the
smowton/fix/kotlin-jar-file-entry-mtimes
branch
from
3a12426 to
4859704
Compare
igfoo
previously approved these changes
May 25, 2022
Previously Kotlin's use of IntelliJ's VirtualFile interface meant we got the containing JAR file's mtime, not that of the individual file entry.
smowton
force-pushed
the
smowton/fix/kotlin-jar-file-entry-mtimes
branch
from
4859704 to
1f2248c
Compare
igfoo
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously Kotlin's use of IntelliJ's VirtualFile interface meant we got the containing JAR file's mtime, not that of the individual file entry.