Swift: Control-flow for key paths #9373
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Swift one can define a kind of "first-class getter" called a key path expression. For example:
As I understand it, the semantics of
a[keyPath: \A.bs[0].x]
is roughly the same as(fun arg:A -> arg.bs[0].x)(a)
, and that's also how I think we'll end up modeling this in dataflow: Each key path expression generates a callable whose body generates a bunch of read steps.This PR makes each key path expression a new
Scope
in the CFG (and aCallable
in dataflow). As can be seen in the tests we're still missing CFG for the body of the key path expressions: Most of theenter #keyPath(...)
CFG nodes flows directly to aTBD (UnresolvedDotExpr)
.