Skip to content

ReDoS: Improve performance in ExponentialBackTracking.qll. #9381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 1, 2022
Merged

ReDoS: Improve performance in ExponentialBackTracking.qll. #9381

merged 2 commits into from
Jun 1, 2022

Conversation

aschackmull
Copy link
Contributor

Two perf fixes:

  1. Magic the shortestDistances HOP.
  2. Fix the join-order in isReachableFromFork.

@aschackmull aschackmull marked this pull request as ready for review May 31, 2022 09:08
@aschackmull aschackmull requested review from a team as code owners May 31, 2022 09:08
@aschackmull aschackmull added the no-change-note-required This PR does not need a change note label May 31, 2022
@aschackmull aschackmull requested a review from erik-krogh May 31, 2022 09:08
erik-krogh
erik-krogh approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@erik-krogh erik-krogh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Assuming the tests pass and the evaluations work out (did you start any?).

Maybe I should rewrite the base-case to start at Nil() in the poly-redos query, it looks better 🤔

@aschackmull
Copy link
Contributor Author

Assuming the tests pass and the evaluations work out (did you start any?).

You should see them now.

@erik-krogh erik-krogh mentioned this pull request May 31, 2022
Closed
@erik-krogh
Copy link
Contributor

You should see them now.

They all look OK.
There is a performance regression in the Java evaluation, but I expect that to be a fluke.
(DB caching in DCA 🤞)

@aschackmull aschackmull merged commit 9abd225 into github:main Jun 1, 2022
@aschackmull aschackmull deleted the redos/perf branch June 1, 2022 08:39
@erik-krogh erik-krogh mentioned this pull request Jun 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erik-krogh erik-krogh erik-krogh approved these changes

Assignees
No one assigned
Labels
Java JS no-change-note-required This PR does not need a change note Python Ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aschackmull @erik-krogh