Swift: simplify GetImmediateParent.qll
#9398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathiasVP
approved these changes
Jun 1, 2022
|
|
||
| /** | ||
| * Gets any of the "immediate" children of `e`. "Immediate" means not taking into account node resolution: for example | ||
| * if the AST child is the first of a series of conversions that would normally be hidden away, this will select the | ||
| * next conversion down the hidden AST tree instead of the corresponding fully uncoverted node at the bottom. | ||
| * This predicate is mainly intended to be used to test uniqueness of parents. | ||
| * Outside this module this file is mainly intended to be used to test uniqueness of parents. |
There was a problem hiding this comment.
I think we should be more aggressive with the wording. For some reason, I can't get Add a suggestion to work 🤔. I'd replace this line with an initial comment saying "INTERNAL: Do not use". You'll see this a lot in QL code.
There was a problem hiding this comment.
Would you place that on both the predicates, or only on getAnImmediateChild?
There was a problem hiding this comment.
I'd place it only on getAnImmediateChild as a replacement to the Outside this module this file is mainly intended to be used to test uniqueness of parents. part of the comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick follow up to #9380, getting rid of the intermediate class implementation there (by leveraging the fact that we can replace
thiswitheusing the fact that it is always the first parameter in the db predicate, and that repeated properties have always the same shape of the parameters to the db predicate).