Skip to content

Go: Sync InlineExpectationsTest #9420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 3, 2022
Merged

Go: Sync InlineExpectationsTest #9420

merged 4 commits into from
Jun 3, 2022

Conversation

RasmusWL
Copy link
Member

@RasmusWL RasmusWL commented Jun 2, 2022

This came up since I wanted to make a change to the shared library, and realized it didn't get synced to Go 😱

@RasmusWL RasmusWL requested a review from a team as a code owner June 2, 2022 13:08
@github-actions github-actions bot added the Go label Jun 2, 2022
@smowton
Copy link
Contributor

smowton commented Jun 2, 2022

I note we haven't registered Go's data-flow libs either

@RasmusWL RasmusWL mentioned this pull request Jun 2, 2022
Merged
@RasmusWL RasmusWL merged commit 07c22a8 into github:main Jun 3, 2022
@RasmusWL RasmusWL deleted the sync-go-inline branch June 3, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smowton smowton smowton approved these changes

Assignees
No one assigned
Labels
Go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RasmusWL @smowton