Swift: add UnknownLocation
#9430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`getLocation()` will now exists for all entities. When there is no valid location, the location will still not be emitted in the DB, but on the QL side we will then assign a special `UnknownLocation` with empty filename and 0 for line/column start/end. This unknown location is currently emitted (with a unique `@` key) at the start of every extraction, but we can move it elsewhere (and possibly in a unique global trap file) at a later stage, possibly after or when we rework the trap file strategy. This should solve flakiness that was observed on the control flow tests, which is probably caused by the `nodes` predicate in the `TestOutput` class in `ControlFlowGraphImplShared.qll` not able to assign a proper rank when the node does not have a location.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getLocation()will now exists for all entities. When there is novalid location, the location will still not be emitted in the DB, but
on the QL side we will then assign a special
UnknownLocationwithempty filename and 0 for line/column start/end.
This unknown location is currently emitted (with a unique
@key) atthe start of every extraction, but we can move it elsewhere (and
possibly in a unique global trap file) at a later stage, possibly after
or when we rework the trap file strategy.
This should solve flakiness that was observed on the control flow tests,
which is probably caused by the
nodespredicate in theTestOutputclass in
ControlFlowGraphImplShared.qllnot able to assign a properrank when the node does not have a location.