Python: Rewrite py/request-without-cert-validation
#9463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ert-validation` This is very much like the Ruby query, except we also have the origin that does the disabling. https://github.com/github/codeql/blob/976daddd36a63bf46836d141d04172e90bb4b33c/ruby/ql/src/queries/security/cwe-295/RequestWithoutValidation.ql#L18-L20
Also fix links
and improve QLDocs a bit
|
We might also consider changing the precision to high. |
yoff
requested changes
Jun 14, 2022
| argumentOrigin.asExpr().(ImmutableLiteral).booleanValue() = false and | ||
| not argumentOrigin.asExpr() instanceof None | ||
| ) | ||
| // TODO: Handling of SSLContext passed as ssl/ssl_context arguments |
There was a problem hiding this comment.
I feel this would need a treatment similar to the SecureProtocol queries, making it difficult to fit into a single predicate like this..
There was a problem hiding this comment.
We'll have to deal with that when we get there. I think having both disablingNode and argumentOrigin would allow us enough flexibility to get pretty far, but we'll see.
Co-authored-by: yoff <lerchedahl@gmail.com>
|
For the record, performance looks fine, and so does the new results from the additional modeling. |
yoff
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also improves library modeling. I did not look into
libtaxiiorpycurl, it did not seem worth the time.I left in a few
TODO: Handling of insecure SSLContext ...for relevant libraries, I'll leave handling those as future work. We're going to be in a much better state with the changes in this PR 👍