JS: add heuristic taint-step for potentially unmodelled libraries #9572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ta query for counting potential unmodelled steps
erik-krogh
changed the title
erik-krogh
changed the title
esbena
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a call to a library function we add a taint-step from the arguments to the return value.
Might be helpful for quickly debugging some missing taint flows.
Also adds a meta query for counting potential unmodelled steps
(See thread on #codeql-dynamic from Jun 8th).
I've tried to enable these steps on a few queries on
microsoft/vscode.The analysis still terminated, so it seems to scale.