Go: Properly escape dash in tracing-config.lua #9617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the pattern didn't match what it was intended to match.
|
Given the amount of time I spent debugging exactly the same issue, would it make sense to add a check to the tracer to issue a warning for such cases? |
cklin
approved these changes
Jun 20, 2022
smowton
approved these changes
Jun 20, 2022
|
@AlexDenisov That would be great, but I don't think it's easy - to issue a correct warning, we'd need to parse Lua regexes, and I don't really want to get into the business of that 😬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the pattern didn't match what it was intended to match.