Swift: Generate better declaration names #9619
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, the name we generate for the declarations:
were both just
f
. This makes it inconvenient to mark the first function overload as a taint source purely based on the name. In addition, the Swift compiler refers to each overload asf(x:y:_:)
andf(z:w:_:)
respectively.With this PR, we generate the expected names (i.e.,
f(x:y:_:)
andf(z:w:_:)
) for the function overloads.Note that as a special case of this, the name of a function
f
with no parameters:is actually
f()
with parentheses! That's a bit confusing to me since it looks like a function call (even though it's actually a reference to the function). This matches the output ofswiftc
, though.This special case required a slight modification to
swift/ql/test/library-tests/dataflow/dataflow/DataFlow.ql
(which is included in c049988).