JS: Downgrade ast_node_symbol relation #9679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickrolfe
approved these changes
Jun 23, 2022
There was a problem hiding this comment.
The downgrade makes sense to me - it drops ast_node_symbol tuples where the node is an @external_module_declaration.
I ran a few hundred of the JS qltests on an old checkout of github/codeql, from before the dbscheme change, using a dist that includes the recent extractor and dbchanges, as well as this downgrade script. They passed, and I observed this downgrade script being applied in the output of codeql test run -vv ....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids introducing a DB inconsistency when downgrading