Swift: extract ImportDecl and ModuleDecl #9772
Conversation
As `ASTMangler` crashes when called on `ModuleDecl`, we simply use its name. This might probably not work reliably in a scenario where multiple modules are compiled with the same name (like `main`), but this is left for future work. At the moment this cannot create DB inconsistencies.
| // TODO the following will be moved to the dispatcher when we start caching swift file objects | ||
| // for the moment, topLevelDecls always contains the current module, which does not have a file | ||
| // associated with it, so we need a special case when there are no top level declarations | ||
| if (topLevelDecls.size() == 1) { |
There was a problem hiding this comment.
I guess there is also no harm to emit the file unconditionally? 🤔
(Just thinking out loud, no action needed).
There was a problem hiding this comment.
yeah, my idea is that we would just unconditionally call visitor.extract(file), which would contain the logic for the emission and caching like the rest of the entities.
| out_ << "// DEBUG: "; | ||
| (out_ << ... << args) << '\n'; | ||
| out_ << "/* DEBUG:\n"; | ||
| (out_ << ... << args) << "\n*/\n"; |
There was a problem hiding this comment.
uh, I forgot to mention the debugging enhancements. There's also emitDebugInfo on the SwiftDispatcher now, that forwards to trap.debug
| // TODO find a more unique string working also when different modules are compiled with the same | ||
| // name | ||
| if (decl.getKind() == swift::DeclKind::Module) { | ||
| return static_cast<const swift::ModuleDecl&>(decl).getRealName().str().str(); |
There was a problem hiding this comment.
Is my understanding correct that this is triggered only from the imports?
There was a problem hiding this comment.
no, not only, because I also added explicitly the current module ModuleDecl to the top-level declarations in SwiftExtractor.cpp
This is a case of imperfect deduplication, yes. It gets worse as the SPM will build lots of different sources with For the moment this is not a problem for the DB, as the entries only have limited information (the name and the |
As
ASTManglercrashes when called onModuleDecl, we simply useits name.
This might probably not work reliably in a scenario where multiple
modules are compiled with the same name (like
main), but this is leftfor future work. At the moment this cannot create DB inconsistencies.
The current module is explicitly passed to be extracted in
SwiftExtractor.cpp.