Swift: collapse TypeRepr hierarchy
#9805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now `TypeRepr` is a final class in the AST, which is more or less just a type with a location in code. As the frontend does not provide a direct way to get a type from a type representation, this information must be provided when fetching the label of a type repr. This meant: * removing the type repr field from `EnumIsCaseExpr`: this is a virtual AST node introduced in place of some kinds of `IsEpxr`. The type repr is still available from the `ConditionalCheckedCastExpr` wrapped by this virtual node, and we will rebuild the original `IsExpr` with the IPA layer. * some logic to get the type of keypath roots has been added to `KeyPathExpr`. This was done to keep the `TypeRepr` to `Type` relation total in the DB, but goes against the design of a dumb extractor. The logic could be moved to QL in the future * in the control flow library, `TypeRepr` children are now ignored. As far as I can tell, there is no runtime evaluation going on in `TypeRepr`s, so it does not make much sense to have control flow through them.
|
QL code looks good to me - I'd appreciate a second set of eyes on the C++, though. |
A type representation may not have a type in unresolved things, which for example pop up in inactive `#if` clauses.
jketema
reviewed
Jul 22, 2022
Co-authored-by: Jeroen Ketema <93738568+jketema@users.noreply.github.com>
jketema
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now
TypeRepris a final class in the AST, which is more or less justa type with a location in code.
As the frontend does not provide a direct way to get a type from a
type representation, this information must be provided when fetching
the label of a type repr.
This meant:
EnumIsCaseExpr: this is a virtualAST node introduced in place of some kinds of
IsEpxr. The typerepr is still available from the
ConditionalCheckedCastExprwrappedby this virtual node, and we will rebuild the original
IsExprwiththe IPA layer.
KeyPathExpr. This was done to keep theTypeReprtoTyperelationtotal in the DB, but goes against the design of a dumb extractor. The
logic could be moved to QL in the future
TypeReprchildren are now ignored. Asfar as I can tell, there is no runtime evaluation going on in
TypeReprs, so it does not make much sense to have control flowthrough them.
swift::ASTNode, we cannot do it forTypeRepr,and we just skip fetching in that case (leading to an assertion). This behaviour
relies on the fact that we only extract
swift::ASTNodein the context ofBraceStmt, where a standaloneTypeRepris actually impossibleWe should probably decouple
AstNodefrom what can appear in aBraceStmt.