Skip to content

Conversation

smowton
Copy link
Contributor

@smowton smowton commented Jul 14, 2022

No description provided.

@smowton smowton requested a review from a team as a code owner July 14, 2022 10:20
@github-actions github-actions bot added the Java label Jul 14, 2022
aschackmull
aschackmull previously approved these changes Jul 14, 2022
@smowton smowton force-pushed the smowton/admin/wildcard-substitution-test branch from 704967a to 93f23df Compare July 21, 2022 08:23
aschackmull
aschackmull previously approved these changes Jul 28, 2022
Copy link
Contributor

@aschackmull aschackmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible to me.

@smowton smowton force-pushed the smowton/admin/wildcard-substitution-test branch from 93f23df to 1737ed5 Compare July 28, 2022 14:52
Copy link
Collaborator

@adityasharad adityasharad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proxying the existing approval, which was dismissed when the PR was rebased.

@smowton smowton merged commit e140d2a into github:main Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants