QL: Query for detecting unused parameter in override methods #9827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erik-krogh
force-pushed
the
overrideAny
branch
3 times, most recently
from
684ddb8 to
43907d0
Compare
erik-krogh
changed the title
erik-krogh
force-pushed
the
overrideAny
branch
from
43907d0 to
460eddd
Compare
kaeluka
previously approved these changes
Nov 8, 2022
There was a problem hiding this comment.
I'm not sure if the very-high precision makes sense, since the query (in practice) tends to find benign cases. Alternatively, perhaps have the message explain the problem a bit better.
Other than that, I'd only improve the error message a bit to make the fix a bit easier.
The warnings found look good to me (JS and others).
Giving an approve as most of this is quite opinionated and I want the decision to be your's 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All current results are benign because the type of the unmentioned parameter is small.
But it is very hard to statically determine that the type is small. (E.g. one is an abstract class, where all (transitive) overrides are small).
The fix to remove the alert for the benign results is just to insert
exists(param)instead ofany().I did try to remove the
pred.hasAnnotation("override")restriction, but that just gave me more noise.