Swift: mangle TypeAliasDecls differently #9921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redsun82
reviewed
Jul 29, 2022
Comment on lines
+299
to
+306
| if (decl.getKind() == swift::DeclKind::TypeAlias) { | ||
| return mangler.mangleEntity(&decl); | ||
| } |
There was a problem hiding this comment.
I guess this warrants a comment explaining why we treat this differently. Even if we don't know the root cause requiring this, it'd be good to give a short description of the example requiring this (mentioning CFXML type aliases)
There was a problem hiding this comment.
or maybe, as mangledName is already on swift::ValueDecl, we can just ditch mangleAnyDecl and only use mangleEntity?
AlexDenisov
force-pushed
the
alexdenisov/type-alias-mangling
branch
from
7c24fae to
34edb25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.