Skip to content

Conversation

MathiasVP
Copy link
Contributor

Now that we have comment extraction we can start to make use of the InlineExpectationsTest framework. This PR adds the framework and instantiates it for Swift, but it doesn't actually use it for anything yet.

Once we've merged this PR we can start to make use of it for writing dataflow tests.

@MathiasVP MathiasVP requested a review from a team as a code owner August 5, 2022 10:54
@github-actions github-actions bot added the Swift label Aug 5, 2022
}
}

/* Note: These next three classes correspond to all the possible values of type `TColumn`. */

Check warning

Code scanning / CodeQL

Block comment that is not QLDoc

Block comment could be QLDoc for [the below code](1).
Comment on lines +5 to +9
/**
* Represents a line comment.
* Unlike the `SingleLineComment` class, however, the string returned by `getContents` does _not_
* include the preceding comment marker (`//`).
*/

Check warning

Code scanning / CodeQL

Class QLDoc style.

The QLDoc for a class should start with 'A', 'An', or 'The'.
Copy link
Contributor

@AlexDenisov AlexDenisov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AlexDenisov AlexDenisov merged commit d3e5449 into github:main Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants