Use StrcpyFunction in cpp/bad-strncpy-size #9998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffw0
reviewed
Aug 10, 2022
| wchar_t buf2[20]; | ||
| const wchar_t *str = L"01234567890123456789"; | ||
|
|
||
| wcsxfrm_l(buf1, str, sizeof(buf1), nullptr); // BAD (but not a StrncpyFlippedArgs bug) |
There was a problem hiding this comment.
(but not a StrncpyFlippedArgs bug)
I'm not sure what you're saying here, the query appears to have flagged this line.
There was a problem hiding this comment.
Yeah, good point... test9() is a copy of test2() pretty much, including the comments, and has the same behaviour. Namely, that line is flagged because (I'm guessing) it falls under the "Fixed sized case", which is not exactly a case of "flipped" args. At least, that's how I interpreted the original comment.
Added wcsxfrm_l, which is not currently caught by the query, meaning that in this case a successful test implies missing functionality.
As a result, the query gets access to more types of strncpy-like functions, as demonstrated by test.cpp, which now "fails" (i.e. works) for the new test cases instroduced in the previous commit.
Add output lines for the newly implemented test case, test.cpp/test9().
d10c
force-pushed
the
use-strcpyfunction-in-bad-strncpy-size
branch
from
265e3d8 to
05f4f98
Compare
geoffw0
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
wcsxfrm_l) to StrncpyFlippedArgs's test.cpp.