Skip to content
This repository was archived by the owner on Sep 22, 2022. It is now read-only.

Fix autofocusing when details is not open & preload toggling #32

Merged
merged 2 commits into from
Apr 9, 2019
Merged

Fix autofocusing when details is not open & preload toggling #32

merged 2 commits into from
Apr 9, 2019

Conversation

muan
Copy link
Contributor

@muan muan commented Apr 8, 2019

Found two issues while upgrading:

  1. on mouseover preload triggers and autofocus is called even though dialog is still closed
  2. removing preload attribute while src is present does not remove the event listener because removeEventListener is only called when this.src is falsey.

@muan muan requested a review from a team April 8, 2019 20:31
mislav
mislav approved these changes Apr 9, 2019
View reviewed changes
Copy link

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catches! 💎

@muan muan merged commit 7522db2 into master Apr 9, 2019
@muan muan deleted the open-focus branch April 9, 2019 16:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
3 more reviewers

@mislav mislav mislav approved these changes

@keithamus keithamus keithamus approved these changes

@dgraham dgraham dgraham approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@muan @mislav @keithamus @dgraham