Skip to content
This repository was archived by the owner on Nov 1, 2017. It is now read-only.

Explain :user means username, not ID. #543

Merged
merged 1 commit into from
Jun 25, 2014

Conversation

cirosantilli
Copy link
Contributor

It's the first question that comes to mind when you see :user, and that's the first place I searched for an answer.

@gjtorikian
Copy link
Contributor

I only see two specific instances of :user on this page. It might be better to just substitute all :user strings with :username to avoid confusion, rather than the paragraph note.

@cirosantilli
Copy link
Contributor Author

This would be a better solution, but it would still leave things unclear about the other parts of the documentation which still use :user: git grep :user shows up quite a few.

If they are all actually usernames, shall I perl -lapi it?

@gjtorikian gjtorikian merged commit 0709686 into github:master Jun 25, 2014
@gjtorikian
Copy link
Contributor

This would be a better solution, but it would still leave things unclear about the other parts of the documentation which still use :user: git grep :user shows up quite a few.

Indeed.

Per 66406d9, I've gone through and changed the (correct) references of :user to :username to make this clearer to readers.

Thanks for bringing this up! 🤘

@cirosantilli cirosantilli deleted the username-not-id branch June 25, 2014 06:45
jatoben added a commit that referenced this pull request May 14, 2015
Search indexing API takes JSON input
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants