Skip to content

docs: change tag-ignore to tags-ignore #16174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2022
Merged

docs: change tag-ignore to tags-ignore #16174

merged 1 commit into from
Mar 10, 2022

Conversation

roerohan
Copy link
Contributor

@roerohan roerohan commented Mar 10, 2022 •
edited
Loading

Why:

There was a typo in the documentation, tags-ignore was spelled tag-ignore.

What's being changed:

image

The typo mentioned above is fixed in this PR.

Check off the following:

  • x ] I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome
Copy link

welcome bot commented Mar 10, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 10, 2022
@roerohan roerohan changed the title fix: change tag-ignore to tags-ignore docs: change tag-ignore to tags-ignore Mar 10, 2022
@ramyaparimi ramyaparimi added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Mar 10, 2022
@ramyaparimi
Copy link
Contributor

@roerohan
Thanks so much for opening a PR! I'll get this triaged for review ⚡

mchammer01
mchammer01 approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roerohan - thanks for spotting this inaccuracy, LGTM ✨

@mchammer01 mchammer01 merged commit a6413f6 into github:main Mar 10, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@roerohan roerohan deleted the patch-2 branch March 10, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchammer01 mchammer01 mchammer01 approved these changes

Assignees
No one assigned
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roerohan @ramyaparimi @mchammer01