Skip to content

Conversation

brcrista
Copy link
Contributor

@brcrista brcrista commented Apr 8, 2022

Why:

Closes issue link

What's being changed:

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Apr 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
content/admin/configuration/configuring-your-enterprise/configuring-rate-limits.md Modified Original
content/admin/github-actions/getting-started-with-github-actions-for-your-enterprise/getting-started-with-github-actions-for-github-enterprise-server.md Modified Original

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team enterprise Content relating to GitHub Enterprise waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Apr 8, 2022
@ramyaparimi
Copy link
Contributor

@brcrista
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@0675712745

This comment was marked as spam.

Copy link
Contributor

@mattpollard mattpollard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brcrista, thanks for this! Looking good 🚀 I've suggested some changes below to get things aligned with our typical style for the documentation. Let me know if you have any questions.

Given the density of this information, I could imagine this content living in its own article with other administrative content about GitHub Actions in the future—but this is a solid start for now, though. No need to move anything around further 😄

As I don't write for Actions often, I'm also going to have someone from our Actions focus area take a look to ensure everything's good here 👀

@ethomson
Copy link
Contributor

I think that @mattpollard's suggestions are excellent, I only had one minor suggestions which you can feel free to disregard if you disagree.

brcrista and others added 3 commits April 15, 2022 13:47
Co-authored-by: Matt Pollard <mattpollard@users.noreply.github.com>
mattpollard and others added 2 commits April 18, 2022 10:51
Co-authored-by: Brian Cristante <33549821+brcrista@users.noreply.github.com>
mattpollard
mattpollard previously approved these changes Apr 18, 2022
Copy link
Contributor

@mattpollard mattpollard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡ Thanks for being open to feedback, @brcrista! And thanks for your suggestions, @ethomson. If y'all are satisfied with this, we can get it merged, and it'll automatically go live with the rest of the GitHub Enterprise Server 3.5 documentation. We can also leave the pull request open here for a couple of days in case any of the other Actions writers want to take a look.

Copy link
Contributor

@lucascosti lucascosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @brcrista and @mattpollard! This looks good from an Actions docs POV.

I made a suggestion, and a couple of small fixes 🙂

Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>
@mattpollard
Copy link
Contributor

@brcrista, mind deleting assets/images/enterprise/actions/actions-rate-limited.png? I'll merge after that's done!

@brcrista
Copy link
Contributor Author

@mattpollard done!

@lucascosti many thanks for the thorough review!

@lucascosti lucascosti enabled auto-merge (squash) April 20, 2022 00:37
@lucascosti lucascosti merged commit c59531e into github:main Apr 20, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@brcrista brcrista deleted the brcrista/ghes-3.5-actions-rate-limit branch April 20, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team enterprise Content relating to GitHub Enterprise waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants