-
Notifications
You must be signed in to change notification settings - Fork 63.1k
Configurable rate limit for GitHub Actions on GHES #16945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable rate limit for GitHub Actions on GHES #16945
Conversation
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request. |
@brcrista |
This comment was marked as spam.
This comment was marked as spam.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brcrista, thanks for this! Looking good 🚀 I've suggested some changes below to get things aligned with our typical style for the documentation. Let me know if you have any questions.
Given the density of this information, I could imagine this content living in its own article with other administrative content about GitHub Actions in the future—but this is a solid start for now, though. No need to move anything around further 😄
As I don't write for Actions often, I'm also going to have someone from our Actions focus area take a look to ensure everything's good here 👀
content/admin/configuration/configuring-your-enterprise/configuring-rate-limits.md
Outdated
Show resolved
Hide resolved
content/admin/configuration/configuring-your-enterprise/configuring-rate-limits.md
Outdated
Show resolved
Hide resolved
content/admin/configuration/configuring-your-enterprise/configuring-rate-limits.md
Outdated
Show resolved
Hide resolved
content/admin/configuration/configuring-your-enterprise/configuring-rate-limits.md
Outdated
Show resolved
Hide resolved
content/admin/configuration/configuring-your-enterprise/configuring-rate-limits.md
Outdated
Show resolved
Hide resolved
content/admin/configuration/configuring-your-enterprise/configuring-rate-limits.md
Outdated
Show resolved
Hide resolved
content/admin/configuration/configuring-your-enterprise/configuring-rate-limits.md
Outdated
Show resolved
Hide resolved
...ions-for-your-enterprise/getting-started-with-github-actions-for-github-enterprise-server.md
Outdated
Show resolved
Hide resolved
I think that @mattpollard's suggestions are excellent, I only had one minor suggestions which you can feel free to disregard if you disagree. |
Co-authored-by: Matt Pollard <mattpollard@users.noreply.github.com>
content/admin/configuration/configuring-your-enterprise/configuring-rate-limits.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Brian Cristante <33549821+brcrista@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚡ Thanks for being open to feedback, @brcrista! And thanks for your suggestions, @ethomson. If y'all are satisfied with this, we can get it merged, and it'll automatically go live with the rest of the GitHub Enterprise Server 3.5 documentation. We can also leave the pull request open here for a couple of days in case any of the other Actions writers want to take a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @brcrista and @mattpollard! This looks good from an Actions docs POV.
I made a suggestion, and a couple of small fixes 🙂
content/admin/configuration/configuring-your-enterprise/configuring-rate-limits.md
Outdated
Show resolved
Hide resolved
content/admin/configuration/configuring-your-enterprise/configuring-rate-limits.md
Outdated
Show resolved
Hide resolved
...ions-for-your-enterprise/getting-started-with-github-actions-for-github-enterprise-server.md
Outdated
Show resolved
Hide resolved
content/admin/configuration/configuring-your-enterprise/configuring-rate-limits.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>
@brcrista, mind deleting assets/images/enterprise/actions/actions-rate-limited.png? I'll merge after that's done! |
@mattpollard done! @lucascosti many thanks for the thorough review! |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
Closes issue link
What's being changed:
Check off the following:
Writer impact (This section is for GitHub staff members only):