Skip to content

Conversation

dsame
Copy link
Contributor

@dsame dsame commented Jul 26, 2022

Why:

One of user had a problem with the docker in self-hosted environment. The investigation showed it used the engine installed with snap and that was a reason of the problem.

Original issue: actions/setup-java#348

What's being changed (if available, include any code snippets, screenshots, or gifs):

I added a sectionDocker engine setup

Check off the following:

  • [ x] I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

One of user had a problem with the docker in self-hosted environment. The investigation showed it used the engine installed with snap and that was a reason of the problem.

Original issue: actions/setup-java#348
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jul 26, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/using-github-hosted-runners/about-github-hosted-runners.md fpt
ghec
ghes@ 3.6 3.5 3.4 3.3 3.2
fpt
ghec
ghes@ 3.6 3.5 3.4 3.3 3.2

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

marko-zivic-93
marko-zivic-93 previously approved these changes Jul 26, 2022
@cmwilson21
Copy link
Contributor

@dsame Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Jul 27, 2022
Copy link
Contributor

@martin389 martin389 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 👍 I've add some small edits in a suggestion. You mentioned this occurred in a self-hosted runner environment, so would it make sense to move this section to the self-hosted runner docs "Customizing the containers used by jobs"? This is the applicable file: https://github.com/github/docs/blob/main/content/actions/hosting-your-own-runners/customizing-the-containers-used-by-jobs.md

@dsame dsame requested a review from martin389 September 12, 2022 06:29
@martin389
Copy link
Contributor

Addressing this in an internal PR, so that it can be moved to the self-hosted runner troubleshooting section.

@martin389
Copy link
Contributor

These changes have now shipped in a separate PR. The content will be live here in a few minutes: https://docs.github.com/en/actions/hosting-your-own-runners/monitoring-and-troubleshooting-self-hosted-runners#checking-which-docker-engine-is-installed-on-the-runner

Thanks for the PR, @dsame 👍

@martin389 martin389 closed this Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants