Skip to content

Conversation

joshjohanning
Copy link
Contributor

@joshjohanning joshjohanning commented Aug 31, 2022

Why:

Closes #19904

cc @dne @lucascosti

What's being changed (if available, include any code snippets, screenshots, or gifs):

Entirely removing the local action reference since with a reusable workflow, it's confusing.

The local action needs to live in the calling repository, not the reusable workflow repository.

I just used a generic/non-existent my-org/my-action@main action reference instead to not confuse multiple topics.

image

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Aug 31, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/using-workflows/reusing-workflows.md fpt
ghec
ghes@ 3.6 3.5 3.4
fpt
ghec
ghes@ 3.6 3.5 3.4

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

lucascosti
lucascosti previously approved these changes Sep 1, 2022
Copy link
Contributor

@lucascosti lucascosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @joshjohanning! I made a slight change to the action to match our usual style (e.g. using octo-org as an example, and using a tag as a ref). I agree that not showing a local action should make things a lot clearer. 🙇‍♂️

@lucascosti lucascosti merged commit 4a6d622 into github:main Sep 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2022

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@joshjohanning
Copy link
Contributor Author

@lucascosti perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Do not begin working on this issue until triaged by the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix misleading example of reusable workflows
2 participants