Skip to content

Conversation

eroullit
Copy link
Contributor

@eroullit eroullit commented Sep 2, 2022

security-extended is an extension of the default queries (aka security), so any query in security is also in security-extended.

Why:

For some, it is unclear that the CodeQL security pack is contained in the security-extended pack though it is made very clear that security-extended is contained in security-and-quality.

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

security-extended is an extension of security, so any query in security is also in security-extended.
@welcome
Copy link

welcome bot commented Sep 2, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Sep 2, 2022
@cmwilson21
Copy link
Contributor

👋 @eroullit Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review codeql Content related to CodeQL and removed triage Do not begin working on this issue until triaged by the team labels Sep 2, 2022
Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eroullit - many thanks for this update to the docs ✨

You change is a great improvement in clarity 🚀

I'll approve the change and get this pull request ready to merge. Once merged, you should see your changes live within the next day.

@felicitymay felicitymay enabled auto-merge (squash) September 5, 2022 10:53
@felicitymay felicitymay merged commit 3609a98 into github:main Sep 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2022

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@eroullit eroullit deleted the patch-2 branch September 5, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codeql Content related to CodeQL content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants