Skip to content

Conversation

andreasabel
Copy link
Contributor

It will delete the caches of the base branch, not the PR branch. Needs fixing! I added an alert in comments that this example doesn't work.

Evidence here: https://github.com/agda/agda/actions/runs/4025940394/jobs/6919801891#step:3:5
(Note: these logs will be removed by github after some time.)

It will delete the caches of the base branch, not the PR branch.  Needs fixing!
I added an alert in comments that this example doesn't work.
@welcome
Copy link

welcome bot commented Jan 27, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jan 27, 2023
@github-actions
Copy link
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/using-workflows/caching-dependencies-to-speed-up-workflows.md fpt
ghec
ghes@ 3.7 3.6 3.5
fpt
ghec
ghes@ 3.7 3.6 3.5

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Contributor

@andreasabel Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Jan 30, 2023
@cmwilson21
Copy link
Contributor

@andreasabel Actually after looking at it, this PR would be better opened as issue as this is a report of a discrepancy. So I'm going to go ahead and close this PR. 💛

Would you mind taking the information in your note and creating a new issue with it? Then I can get this properly triaged and up for review 👍

@andreasabel
Copy link
Contributor Author

@cmwilson21 : Ok, Courtney, I opened an issue instead:

(This is my first report here, so I don't know my ways around here yet. Initially, I followed the "Contribute" button in the docs which brought me to the editor to open a PR.)

@cmwilson21
Copy link
Contributor

cmwilson21 commented Jan 31, 2023

@andreasabel Sounds great! Take a look at the contributing.md if you want to explore further for future contributions 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants