Skip to content

'cleanup caches' example workflow is wrong and harmful! #23530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

'cleanup caches' example workflow is wrong and harmful! #23530

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions content/actions/using-workflows/caching-dependencies-to-speed-up-workflows.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,10 @@ jobs:

REPO={% raw %}${{ github.repository }}{% endraw %}
BRANCH={% raw %}${{ github.ref }}{% endraw %}
## This is wrong!!
## If invoked by a closing PR, BRANCH ends up to be the base branch, e.g. master.
## This job will then remove exactly the wrong caches.
## HARMFUL EXAMPLE, should be fixed immediately by some knowledgeable person.

echo "Fetching list of cache key"
cacheKeysForPR=$(gh actions-cache list -R $REPO -B $BRANCH | cut -f 1 )
Expand Down