Skip to content

About GitHub Classroom #24464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 44 commits into from
Mar 27, 2023
Merged

About GitHub Classroom #24464

merged 44 commits into from
Mar 27, 2023

Conversation

OlayinkaAtobiloye
Copy link
Contributor

@OlayinkaAtobiloye OlayinkaAtobiloye commented Mar 15, 2023

Why:

Closes ISSUE

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 15, 2023
@OlayinkaAtobiloye
Copy link
Contributor Author

Hi @sabrowning1! Started working on the conceptual article! Made a draft PR to signify it is still a wip. Please check this out when you are chanced!

@github-actions
Copy link
Contributor

github-actions bot commented Mar 15, 2023

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
education/explore-the-benefits-of-teaching-and-learning-with-github-education/github-global-campus-for-students/about-github-global-campus-for-students.md fpt
fpt
education/explore-the-benefits-of-teaching-and-learning-with-github-education/github-global-campus-for-students/apply-to-github-global-campus-as-a-student.md fpt
fpt
education/index.md fpt
fpt
New file: education/manage-coursework-with-github-classroom/get-started-with-github-classroom/about-github-classroom.md fpt
fpt
education/manage-coursework-with-github-classroom/get-started-with-github-classroom/index.md fpt
fpt
education/manage-coursework-with-github-classroom/teach-with-github-classroom/create-a-group-assignment.md fpt
fpt

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

Copy link
Contributor

@sabrowning1 sabrowning1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting on this! 😁 These suggestions should fix the frontmatter 👍🏼

OlayinkaAtobiloye and others added 3 commits March 15, 2023 17:41
…started-with-github-classroom/about-github-classroom.md

Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
…started-with-github-classroom/about-github-classroom.md

Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
…started-with-github-classroom/about-github-classroom.md

Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
Copy link
Contributor

@sabrowning1 sabrowning1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for working on this @OlayinkaAtobiloye! 😁 This is looking great, I've left some initial feedback 👍🏼

OlayinkaAtobiloye and others added 8 commits March 17, 2023 19:03
…started-with-github-classroom/about-github-classroom.md

Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
…started-with-github-classroom/about-github-classroom.md

Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
…started-with-github-classroom/about-github-classroom.md

Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
…started-with-github-classroom/about-github-classroom.md

Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
…started-with-github-classroom/about-github-classroom.md

Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
…started-with-github-classroom/about-github-classroom.md

Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
…started-with-github-classroom/about-github-classroom.md

Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
Copy link
Contributor

@sabrowning1 sabrowning1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working through that first round of feedback @OlayinkaAtobiloye, this is really taking shape! 💖 I've left some comments below focused mainly on word choice, clarity, and concision. The only other suggestion I have now is to order the features alphabetically—since this is almost an unordered list, I'd say we should go with the style guide. Alphabetizing the features should make it easier for users looking for specific features to skim that section 🙂

Thanks again for your hard work on this! As usual, feel free to ping me with any questions 😁

OlayinkaAtobiloye and others added 5 commits March 22, 2023 18:46
…started-with-github-classroom/about-github-classroom.md

Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
…started-with-github-classroom/about-github-classroom.md

Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
…started-with-github-classroom/about-github-classroom.md

Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
…started-with-github-classroom/about-github-classroom.md

Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
…started-with-github-classroom/about-github-classroom.md

Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
OlayinkaAtobiloye and others added 7 commits March 22, 2023 18:51
…started-with-github-classroom/about-github-classroom.md

Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
…started-with-github-classroom/about-github-classroom.md

Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
…started-with-github-classroom/about-github-classroom.md

Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
…started-with-github-classroom/about-github-classroom.md

Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
…started-with-github-classroom/about-github-classroom.md

Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
OlayinkaAtobiloye and others added 2 commits March 23, 2023 17:51
…started-with-github-classroom/index.md

Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
…started-with-github-classroom/index.md

Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
@OlayinkaAtobiloye OlayinkaAtobiloye marked this pull request as ready for review March 23, 2023 16:53
@mchammer01 mchammer01 self-requested a review March 24, 2023 16:04
mchammer01
mchammer01 previously approved these changes Mar 24, 2023
Copy link
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OlayinkaAtobiloye 👋🏻 - great work 💖
I added a few comments and made a few suggestions. Feel free to ignore those you don't agree with, as some may be due to personal preference.
The two main points I'd like you to take a look at are:

  • the links to the articles in the "Further reading" section of the new article.
  • whether you should (or want to) add links to the new article from existing GitHub Classroom articles

Hope this review helps ✨

OlayinkaAtobiloye and others added 8 commits March 24, 2023 18:11
…started-with-github-classroom/about-github-classroom.md

Co-authored-by: mc <42146119+mchammer01@users.noreply.github.com>
…started-with-github-classroom/about-github-classroom.md

Co-authored-by: mc <42146119+mchammer01@users.noreply.github.com>
…started-with-github-classroom/about-github-classroom.md

Co-authored-by: mc <42146119+mchammer01@users.noreply.github.com>
…started-with-github-classroom/about-github-classroom.md

Co-authored-by: mc <42146119+mchammer01@users.noreply.github.com>
…started-with-github-classroom/about-github-classroom.md

Co-authored-by: mc <42146119+mchammer01@users.noreply.github.com>
…started-with-github-classroom/about-github-classroom.md

Co-authored-by: mc <42146119+mchammer01@users.noreply.github.com>
@OlayinkaAtobiloye
Copy link
Contributor Author

@OlayinkaAtobiloye 👋🏻 - great work 💖 I added a few comments and made a few suggestions. Feel free to ignore those you don't agree with, as some may be due to personal preference. The two main points I'd like you to take a look at are:

  • the links to the articles in the "Further reading" section of the new article.
  • whether you should (or want to) add links to the new article from existing GitHub Classroom articles

Hope this review helps ✨

Hi @mchammer01, thanks for the review - super helpful!❤️ Made some changes, please confirm if this is good to go when you are chanced.✨

@mchammer01
Copy link
Contributor

@OlayinkaAtobiloye - thanks for addressing my comments ✨
LGTM :shipit:

Copy link
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great ⚡

@sabrowning1 sabrowning1 enabled auto-merge March 27, 2023 20:09
@sabrowning1 sabrowning1 merged commit ec20f90 into github:main Mar 27, 2023
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Do not begin working on this issue until triaged by the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new conceptual article 'About GitHub Classroom'
3 participants