-
Notifications
You must be signed in to change notification settings - Fork 63.1k
Update workflow-commands-for-github-actions.md #24924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
reopening after testing more, looks like the job outputs are empty when set up like this example, and it contradicts: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-output-parameter |
Thanks for the PR @MayCXC, I'll get this triaged for review. |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change makes sense to me 👍
for this bit further down in the next job to work:
SECRET_HANDLE="${{ needs.secret-generator.outputs.handle }}"{% endraw %}
the handle
output needs to be defined in the secret-generator
job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for catching this and opening a PR @MayCXC! ✨ I've requested one small formatting change below, then this should be good to go.
content/actions/using-workflows/workflow-commands-for-github-actions.md
Outdated
Show resolved
Hide resolved
Hi @MayCXC Thanks for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋🏼 @MayCXC, I've committed my suggestion and will merge this shortly. Thanks again for your help maintaining our docs! ✨
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
The behavior I currently see in workflows is that outputs are not present when not defined in a job, like they were in this example.
What's being changed (if available, include any code snippets, screenshots, or gifs):
workflow docs example
Check off the following: