Skip to content

fix wrong activity type starred #27127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 31, 2023
Merged

fix wrong activity type starred #27127

merged 2 commits into from
Jul 31, 2023

Conversation

suzuki-shunsuke
Copy link
Contributor

@suzuki-shunsuke suzuki-shunsuke commented Jul 28, 2023 •
edited
Loading

Why:

Closes: #27129

What's being changed (if available, include any code snippets, screenshots, or gifs):

Fix the wrong activity type starred.
The correct activity type is started.

I've confiremd the event wasn't triggered if the activity type was starred but the event was triggered if the activity type is started.

Reproduction code: https://github.com/suzuki-shunsuke/github-docs-27127

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

  • For content changes, I have completed the self-review checklist.

@suzuki-shunsuke
fix wrong action type starred
a5a7a0a 
The correct action type is `started`.
I've confiremd the event wasn't triggered if the action type was `starred`
but the event was triggered if the action type is `started`.
@welcome
Copy link

welcome bot commented Jul 28, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jul 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 28, 2023 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/using-workflows/events-that-trigger-workflows.md fpt
ghec
ghes@ 3.9 3.8 3.7 3.6
ghae
 fpt
ghec
ghes@ 3.9 3.8 3.7 3.6
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@suzuki-shunsuke suzuki-shunsuke mentioned this pull request Jul 28, 2023
Closed
1 task
@suzuki-shunsuke suzuki-shunsuke marked this pull request as ready for review July 28, 2023 10:07
@suzuki-shunsuke suzuki-shunsuke changed the title fix wrong action type starred fix wrong activity type starred Jul 28, 2023
@cmwilson21 cmwilson21 removed the triage Do not begin working on this issue until triaged by the team label Jul 28, 2023
@cmwilson21
Copy link
Contributor

@suzuki-shunsuke Thank you for opening a PR and linking it to your issue! ✨

I think that the current usage of "starred" right here is correct, but I'll double check with the team.

In the meantime, if you'd like to find other ways to contribute, check out our help wanted section to find open issues you can work on. 👍

Thank you for your interest in improving GitHub Docs! 💖

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review labels Jul 28, 2023
@suzuki-shunsuke
Copy link
Contributor Author

suzuki-shunsuke commented Jul 28, 2023 •
edited
Loading

Thank you for your review.

Could you check this?

I've confiremd the event wasn't triggered if the activity type was starred but the event was triggered if the activity type is started.

Reproduction code: https://github.com/suzuki-shunsuke/github-docs-27127

You can reproduce the issue by the following steps. https://github.com/suzuki-shunsuke/github-docs-27127#how-to-reproduce-the-issue

If the document is correct, this means a bug of GitHub Actions that GitHub Actions's watch event's activity type should be starred, but actually is started.
If so, I'll create an issue about this.
But even if this is a bug, the activity type should not be easily changed for compatibility.
One of ideas for compatibility is to support both starred and started, but it may be confusing.

hubwriter
hubwriter approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@hubwriter hubwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@suzuki-shunsuke - Great catch and correction. 🎉

Many thanks for your work in the issue to confirm the behavior, and for raising this PR to correct the docs.

Much appreciated.

I'll get this merged and published. 👍

@hubwriter hubwriter enabled auto-merge July 31, 2023 09:52
@hubwriter hubwriter added this pull request to the merge queue Jul 31, 2023
Merged via the queue into github:main with commit 3d161ca Jul 31, 2023
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@suzuki-shunsuke suzuki-shunsuke deleted the fix-typo-starred branch July 31, 2023 10:21
@suzuki-shunsuke suzuki-shunsuke mentioned this pull request Aug 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hubwriter hubwriter hubwriter approved these changes

Assignees
No one assigned
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

watch event's activity type starred is wrong. The correct activity type is started
3 participants
@suzuki-shunsuke @cmwilson21 @hubwriter