Skip to content

Conversation

AlexPykavy
Copy link
Contributor

@AlexPykavy AlexPykavy commented Sep 3, 2023

Why:

Use the same port for the loopback OAuth redirect_url both in the description and code block to avoid confusion.

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

@welcome
Copy link

welcome bot commented Sep 3, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Sep 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2023

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
apps/oauth-apps/building-oauth-apps/authorizing-oauth-apps.md fpt
ghec
ghes@ 3.10 3.9 3.8 3.7 3.6
ghae
fpt
ghec
ghes@ 3.10 3.9 3.8 3.7 3.6
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Contributor

@AlexPykavy Thanks for submitting a PR! Would you mind filling out the "Why" section with a short description of the change you are making? That'll make it easier for review. Then I'll get it triaged 👍

@cmwilson21 cmwilson21 added the more-information-needed More information is needed to complete review label Sep 5, 2023
@AlexPykavy
Copy link
Contributor Author

@cmwilson21 , updated.

@cmwilson21
Copy link
Contributor

@AlexPykavy Thank you!! That's really helpful to our team to have that information. I'll get this triaged for review! ✨

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review github apps Content related to GitHub Apps and removed triage Do not begin working on this issue until triaged by the team more-information-needed More information is needed to complete review labels Sep 6, 2023
Copy link
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this update! We'll get this merged for you.

@skedwards88 skedwards88 added the ready to merge This pull request is ready to merge label Sep 8, 2023
@Amiraliarab1367

This comment was marked as spam.

@Romana100198

This comment was marked as spam.

@skedwards88 skedwards88 added this pull request to the merge queue Sep 12, 2023
Merged via the queue into github:main with commit 567416b Sep 12, 2023
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@Frifireolnyheadshot

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team github apps Content related to GitHub Apps ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants